Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(NcAppSidebarTabs): force color-main-text for icons #6189

Merged
merged 1 commit into from
Nov 4, 2024
Merged

fix(NcAppSidebarTabs): force color-main-text for icons #6189

merged 1 commit into from
Nov 4, 2024

Conversation

Antreesy
Copy link
Contributor

@Antreesy Antreesy commented Nov 4, 2024 •
edited
Loading

☑️ Resolves

  • Continuation of fix(NcCheckboxRadioSwitch): switch may always have checked-like background #6055
  • Both rules have same specificity (0.4.0):
    • .checkbox-radio-switch--button-variant:not(.checkbox-radio-switch--checked) .checkbox-radio-switch__icon > * in NcChevkboxRadioSwitch
    • .checkbox-content--button-variant .checkbox-content__icon:not(.checkbox-content__icon--checked) > * in NcCheckboxContent
  • so it might come up again sooner or later (noticed when linked new lib to spreed app, but not noifications app)
  • since we have styles overriden for NcAppSidebarTabs specifically, they should force cover both checked and default icon

🖼️ Screenshots

🏚️ Before 🏡 After
image image

🏁 Checklist

  • ⛑️ Tests are included or are not applicable
  • 📘 Component documentation has been extended, updated or is not applicable
  • 3️⃣ Backport to next requested with a Vue 3 upgrade

@Antreesy Antreesy added bug Something isn't working 3. to review Waiting for reviews feature: app-sidebar Related to the app-sidebar component labels Nov 4, 2024
@Antreesy Antreesy added this to the 8.20.0 milestone Nov 4, 2024
@Antreesy Antreesy self-assigned this Nov 4, 2024
@Antreesy Antreesy mentioned this pull request Nov 4, 2024
Open
@susnux susnux merged commit bd4f80a into master Nov 4, 2024
19 checks passed
@susnux susnux deleted the fix/6055/sidebar-tabs-colors branch November 4, 2024 20:54
@susnux
Copy link
Contributor

susnux commented Nov 4, 2024

Backport?

@Antreesy
Copy link
Contributor Author

Antreesy commented Nov 4, 2024

/backport to next

@backportbot backportbot bot mentioned this pull request Nov 4, 2024
Merged
@ShGKme ShGKme changed the title fix: force color-main-text for icons in NcAppSidebarTabs fix(NcAppSidebarTabs): force color-main-text for icons Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShGKme ShGKme ShGKme approved these changes

@susnux susnux susnux approved these changes

@DorraJaouad DorraJaouad Awaiting requested review from DorraJaouad

Assignees

@Antreesy Antreesy

Labels
3. to review Waiting for reviews bug Something isn't working feature: app-sidebar Related to the app-sidebar component
Projects
None yet
Milestone
8.20.0
Development

Successfully merging this pull request may close these issues.
3 participants
@Antreesy @susnux @ShGKme